Code quality configuration for Codeac.io#4
Open
michal-simon wants to merge 6 commits intomarcelofmatos:masterfrom
Open
Code quality configuration for Codeac.io#4michal-simon wants to merge 6 commits intomarcelofmatos:masterfrom
michal-simon wants to merge 6 commits intomarcelofmatos:masterfrom
Conversation
Author
|
Hi Marcelo, how are you doing? I just wanted to ask if you had a chance to look at this PR. Is there anything blocking the merge? Happy to fix it. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Marcelo,
I briefly looked up your repo and saw a good amount of work you have done over here. Good job, man! 🥇
You recently also tried Codeac.io and you probably haven't had a good experience just because of lack of correct configuration and false positives.
I went through the biggest issues in your repository and added configuration to this pull-request to avoid irrelevant problems. I hope this will be helpful for you and find Codeac more useful after this.
Basically I ignored all external dependencies you have stored in the repository. This is just a workaround to help you get better results. The best practice would be to remove it from your repo completely and refer to it in
package.jsonorcomposer.jsoninstead.Let me know if you need any more help.
Michal Šimon
CEO @ Codeac.io
PS: Keep doing open-source, please! We all appreciate your work a lot! :)